Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly filter issue list given no assignees filter #31522

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

kemzeb
Copy link
Contributor

@kemzeb kemzeb commented Jun 28, 2024

Quick fix #31520. This issue is related to #31337.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 28, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 28, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jun 28, 2024
@kemzeb
Copy link
Contributor Author

kemzeb commented Jun 28, 2024

Example without the filter:

Screenshot 2024-06-28 at 9 59 34 AM

Example with:

Screenshot 2024-06-28 at 10 00 20 AM

@kemzeb kemzeb added the backport/v1.22 This PR should be backported to Gitea 1.22 label Jun 28, 2024
@kemzeb
Copy link
Contributor Author

kemzeb commented Jun 28, 2024

I also decided to test the other issue filtering options to see if similar problems occur and they all appear to work fine.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 28, 2024
@lunny
Copy link
Member

lunny commented Jul 11, 2024

Could you also have a test for it to avoid the bug being occupied again?

@kemzeb
Copy link
Contributor Author

kemzeb commented Jul 11, 2024

Yep, I'll see if I can write a regression test for this today

@kemzeb kemzeb force-pushed the fix-issue-list-no-assignees branch from b6fe6b6 to c52de0d Compare July 12, 2024 01:18
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2024
@kemzeb
Copy link
Contributor Author

kemzeb commented Jul 12, 2024

Not sure if its the best place, but I added the regression test to issues/indexer_test.go and ran it on my branch and current main

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 12, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 23, 2024
@silverwind silverwind enabled auto-merge (squash) July 23, 2024 18:04
@silverwind silverwind merged commit c0b5a84 into go-gitea:main Jul 23, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jul 23, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jul 23, 2024
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jul 23, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 24, 2024
* giteaofficial/main:
  use nolyfill to remove some polyfills (go-gitea#31468)
  Properly filter issue list given no assignees filter (go-gitea#31522)
  Run `detectWebAuthnSupport` only on sign-in page (go-gitea#31676)
  fix OIDC introspection authentication (go-gitea#31632)
  Enable direnv (go-gitea#31672)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
wolfogre pushed a commit that referenced this pull request Jul 24, 2024
Backport #31522 by @kemzeb

Quick fix #31520. This issue is related to #31337.

Co-authored-by: Kemal Zebari <[email protected]>
@kemzeb kemzeb deleted the fix-issue-list-no-assignees branch July 29, 2024 21:41
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues belonging to a repository cannot be filtered by "no assignee"
4 participants